-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler : fix deviceshare plugin of add\remove pod #1963
scheduler : fix deviceshare plugin of add\remove pod #1963
Conversation
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
63ec988
to
c937fc8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
+ Coverage 67.55% 67.60% +0.05%
==========================================
Files 420 421 +1
Lines 47058 47145 +87
==========================================
+ Hits 31788 31872 +84
+ Misses 12961 12959 -2
- Partials 2309 2314 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ator-sh#1963)" This reverts commit ad01533.
…tor-sh#1963) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
…1963) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Ⅰ. Describe what this PR does
fix deviceshare plugin of add\remove pod. For example, pod A preempts a pod in node1 in the last round preemption. If the next to schedule pod is pod B, framework will add pod A when RunFiltersWithNominatedsPod. However, the deviceSharePlugin's allocation result of pod A is not stored. As a result, the resources nominated by pod A may be occupied by pod B, although pod B's priority is lower than pod A, this case will be happened in fractional gpu allocation or topology aware allocation.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test